Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: minimum-commission-rate #138

Draft
wants to merge 23 commits into
base: minimum-commission-rate-feature
Choose a base branch
from
Draft

feat: minimum-commission-rate #138

wants to merge 23 commits into from

Conversation

Jonathansumner
Copy link
Member

No description provided.

@Jonathansumner Jonathansumner self-assigned this Feb 3, 2023
@Jonathansumner Jonathansumner changed the title wip: initial push for pairing feat: initial push for pairing Feb 3, 2023
@Jonathansumner Jonathansumner changed the title feat: initial push for pairing feat: minimum-commission-rate Feb 3, 2023
@Jonathansumner Jonathansumner force-pushed the feat/minimum-commission-rate branch from 9372d62 to db28752 Compare May 26, 2023 16:06
@github-actions github-actions bot added C:x/params and removed C:CLI labels May 26, 2023
@github-actions github-actions bot added the C:CLI label Jun 1, 2023
Jonathansumner
Jonathansumner commented Jun 7, 2023
View reviewed changes
x/distribution/keeper/allocation_test.go
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a 2nd pair of eyes, I'd say

Jonathansumner
Jonathansumner commented Jun 8, 2023
View reviewed changes
x/staking/keeper/params.go
@@ -39,6 +39,16 @@ func (k Keeper) BondDenom(ctx sdk.Context) (res string) {
return
}

func (k Keeper) MinCommissionRate(ctx sdk.Context) (res *sdk.Dec) {
Copy link
Member Author

@Jonathansumner Jonathansumner Jun 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

min commission not present - test behaviour when not present, when params don't contain that value

@pbukva pbukva mentioned this pull request Jun 8, 2023
Open
Jonathansumner
Jonathansumner commented Jun 8, 2023
View reviewed changes
x/staking/types/errors.go
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

@pbukva pbukva changed the base branch from main to minimum-commission-rate-feature June 8, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Jonathansumner Jonathansumner

Labels
C:CLI C:Simulations C:x/distribution C:x/gov C:x/slashing C:x/staking Type: ADR Type: Build Type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jonathansumner @ejfitzgerald @pbukva